Skip to content

chore: [StepSecurity] Apply security best practices - #45

Merged
jasuwienas merged 1 commit into
mainfrom
chore/GHA-051217-stepsecurity-remediation
May 26, 2026
Merged

chore: [StepSecurity] Apply security best practices#45
jasuwienas merged 1 commit into
mainfrom
chore/GHA-051217-stepsecurity-remediation

Conversation

@stepsecurity-app

@stepsecurity-app stepsecurity-app Bot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Summary

This pull request has been generated by StepSecurity as part of your enterprise subscription to ensure compliance with recommended security best practices. Please review and merge the pull request to apply these security enhancements.

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Feedback

For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo or contact us via our website.

@stepsecurity-app
[StepSecurity] Apply security best practices
f5369e3 
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@stepsecurity-app
stepsecurity-app Bot requested review from a team as code owners February 5, 2026 12:17
@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown

Test Results

 12 files  ± 0   48 suites   - 6   41m 44s ⏱️ + 3m 39s
171 tests  - 34  167 ✅  - 31  4 💤  - 3  0 ❌ ±0 
226 runs   - 34  222 ✅  - 31  4 💤  - 3  0 ❌ ±0 

Results for commit f5369e3. ± Comparison against base commit c3e400a.

This pull request removes 56 and adds 22 tests. Note that renamed tests count towards both. 
should be able to burn token ‑ TokenManagmentContract Test Suite should be able to burn token
should be able to change ADMIN key to ECDSA_secp256k and perform admin action with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change ADMIN key to ECDSA_secp256k and perform admin action with same contract
should be able to change ADMIN key to contractId and perform admin action with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change ADMIN key to contractId and perform admin action with same contract
should be able to change FREEZE key to ECDSA_secp256k and freeze the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change FREEZE key to ECDSA_secp256k and freeze the token with the same account
should be able to change FREEZE key to contractId and freeze the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change FREEZE key to contractId and freeze the token with same contract
should be able to change PAUSE key to ECDSA_secp256k and pause the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change PAUSE key to ECDSA_secp256k and pause the token with the same account
should be able to change PAUSE key to contractId and pause the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change PAUSE key to contractId and pause the token with same contract
should be able to change WIPE key to ECDSA_secp256k and wipe the token with the same account ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to contractId Positive should be able to change WIPE key to ECDSA_secp256k and wipe the token with the same account
should be able to change WIPE key to contractId and wipe the token with same contract ‑ TokenManagmentContract Test Suite Extended update token info and keys test suite Admin key set to ECDSA_secp256k should be able to change WIPE key to contractId and wipe the token with same contract
should be able to delete token ‑ TokenManagmentContract Test Suite should be able to delete token
…

should claim a single pending NFT airdrop ‑ HIP904Batch3 ClaimAirdropContract Test Suite should claim a single pending NFT airdrop
should claim a single pending fungible token airdrop ‑ HIP904Batch3 ClaimAirdropContract Test Suite should claim a single pending fungible token airdrop
should claim multiple pending fungible token airdrops ‑ HIP904Batch3 ClaimAirdropContract Test Suite should claim multiple pending fungible token airdrops
should fail to airdrop Number.MAX_SAFE_INTEGER + 1 tokens ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to airdrop Number.MAX_SAFE_INTEGER + 1 tokens
should fail to airdrop a token to themselves ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to airdrop a token to themselves
should fail to claim airdrops when NFT does not exist ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to claim airdrops when NFT does not exist
should fail to claim airdrops when NFT serial number does not exist ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to claim airdrops when NFT serial number does not exist
should fail to claim airdrops when receiver does not have a valid account ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to claim airdrops when receiver does not have a valid account
should fail to claim airdrops when sender does not have a valid account ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to claim airdrops when sender does not have a valid account
should fail to claim airdrops when sender has no pending airdrops ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to claim airdrops when sender has no pending airdrops
…
This pull request removes 4 skipped tests and adds 1 skipped test. Note that renamed tests count towards both. 
should be able to update fixed HTS fee and royalty fee in NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee and royalty fee in NFT
should be able to update fixed HTS fee for NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee for NFT
should fail when updating NFT token fees to more than 10 ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when updating NFT token fees to more than 10
should fail when updating fungible token fees to more than 10 ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when updating fungible token fees to more than 10

should fail to delete contract if there is pending airdrop ‑ HIP904Batch3 ClaimAirdropContract Test Suite should fail to delete contract if there is pending airdrop

@jasuwienas
jasuwienas merged commit 368e572 into main May 26, 2026
20 of 24 checks passed
@swirlds-automation

swirlds-automation commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasuwienas jasuwienas jasuwienas approved these changes
@andrewb1269 andrewb1269 andrewb1269 approved these changes
@PavelSBorisov PavelSBorisov Awaiting requested review from PavelSBorisov PavelSBorisov is a code owner automatically assigned from hiero-ledger/github-maintainers

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swirlds-automation @jasuwienas @andrewb1269